FoxMagiskModuleManager icon indicating copy to clipboard operation
FoxMagiskModuleManager copied to clipboard

Add expandable card

Open DerGoogler opened this issue 3 years ago • 5 comments

image

DerGoogler avatar Jun 15 '22 14:06 DerGoogler

I'm a little confused as to what this does, your screenshot doesn't seem to show anything different than now

androidacy-user avatar Jun 15 '22 21:06 androidacy-user

I'm a little confused as to what this does, your screenshot doesn't seem to show anything different than now

Please check https://t.me/Fox2Code_Chat/11849

DerGoogler avatar Jun 16 '22 04:06 DerGoogler

Seems interesting but could lead to bad UX - it's not immediately obvious that users need to press that extra button.

I was honestly thinking you were doing a collapse for lengthy module descriptions like telegram does for long bios

androidacy-user avatar Jun 16 '22 04:06 androidacy-user

I'm conflicted about the PR, I think I'll probably merge this at some point for the next major UI rework release.

Fox2Code avatar Jun 19 '22 07:06 Fox2Code

There is still room to make UI compact in other ways, I think I will use the empty space for something else.

Fox2Code avatar Jul 07 '22 14:07 Fox2Code

👀

HiFiiDev avatar Aug 27 '22 08:08 HiFiiDev

@DerGoogler I'm going to close this as it's now outdated. Feel free to open a new up to date PR - though if you want my advice, stick to collapsing long descriptions and allow it to be toggled off.

androidacy-user avatar Sep 02 '22 14:09 androidacy-user