victory

victory copied to clipboard

Description

• sets ground for working on RN app/symlinked to workspace
• small type adjustments that came with upgrade
• adds demo to pnpm workspace
• adjusts metro config now that it actually supports symlinks
• All examples seem to work except for one chart with a polar prop on it in the VictoryChart example screen, ~~and the VictoryHistogram screen~~ fixed.

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Tested by running on iOS and Android and clicking around. Clicked around web demo.

Checklist: (Feel free to delete this section upon completion)

• [ ] I have included a changeset if this change will require a version change to one of the packages.
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] I have run all builds, tests, and linting and all checks pass
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] My changes generate no new warnings
• [ ] Any dependent changes have been merged and published in downstream modules

⚠️ No Changeset found

Latest commit: c96d7908e85379160842f7d0668040a7944246ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
victory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 9, 2024 9:40pm

@carbonrobot had to rebase main and fix conflicts in the lock file in order to merge

Hello, there was a typo fixed in this PR for position: relative of the VictoryContainer component (it was positition). Could you please release a new version with this fix? Thanks

@Minishlink Thanks for catching that, working on a release right now.

Released in 37.1.2