freactal icon indicating copy to clipboard operation
freactal copied to clipboard

Type codebase with flow

Open aweary opened this issue 7 years ago • 3 comments

I have a feeling some types would make maintaining/refactoring freactal a lot easier. I'm looking at implementing #51 and it would be helpful if everything was well typed first.

cc @ryan-roemer

aweary avatar Dec 01 '17 19:12 aweary

@divmain would you be OK with this?

aweary avatar Dec 01 '17 19:12 aweary

@divmain -- Any last objections to applying flow to freactal? We'd ideally like to get this going soon-ish unless you have objections.

ryan-roemer avatar Dec 06 '17 20:12 ryan-roemer

While I'm a fan of static typing in general, I'm on the fence with this proposal. The freactal code-base is small enough where typing is ideally unnecessary. I think exposing types for library consumers would be fantastic, but I view that as fundamentally separate.

@aweary, which parts of the code-base lead you to feel types would ease maintenance?

divmain avatar Dec 14 '17 10:12 divmain