SMC icon indicating copy to clipboard operation
SMC copied to clipboard

fixed some warnings from compiler

Open burlito opened this issue 12 years ago • 6 comments

burlito avatar Oct 23 '13 11:10 burlito

This would break _DEBUG builds.

tristanheaven avatar Oct 23 '13 20:10 tristanheaven

I'm so sorry, I will fix this asap.

burlito avatar Oct 23 '13 21:10 burlito

Ok, I belive it will work ok now.

burlito avatar Oct 23 '13 23:10 burlito

@tristanheaven or @Quintus - were we able to make use of this patch (or have we already put it to use)? I just was wondering.

@burlito - as I said in another reply - you are welcome to join our team at https://github.com/Secretchronicles/TSC. We are getting close to a new release of the game.

datahead8888 avatar Oct 03 '14 06:10 datahead8888

The patch will not apply to the TSC sourcecode anymore, plus I don’t think simply casting to the unsigned value is the correct way of resolving the compiler warnings. The logic must be fixed, i.e. the variable in quesiton must be unsigned right from the beginning.

Vale, Quintus

Quintus avatar Oct 03 '14 07:10 Quintus

Hi,

Actually this wariabile was in first place signes, there was a some reason why I changed that and recast in other place. however I'm not sure why.

On 10/03/2014 03:40 AM, Marvin Gülker wrote:

The patch will not apply to the TSC sourcecode anymore, plus I don’t think simply casting to the unsigned value is the correct way of resolving the compiler warnings. The logic must be fixed, i.e. the variable in quesiton must be unsigned right from the beginning.

Vale, Quintus

— Reply to this email directly or view it on GitHub https://github.com/FluXy/SMC/pull/5#issuecomment-57765072.

Kind regards, b.

burlito avatar Oct 03 '14 07:10 burlito