fine-uploader

fine-uploader copied to clipboard

Brief description of the changes

Convert all uses of qq.Promise or other promises to require native Promise instead.

What browsers and operating systems have you tested these changes on?

Firefox 59

Have you written unit tests? If not, explain why.

I've migrated existing tests to be async friendly.

I'm going to build off this branch for my product https://dovetailapp.com and give it some production testing. I'll be using the S3 chunked uploader.

Remaining issues

• [x] Replace PromiseOptions with Promise. Check implications of no longer allowing the promise to be resolved by callers (no more .success and .failure).

Wow. I haven’t reviewed any of this yet, but it looks like you put a LOT of work into these changes...

If you’re willing, I’d like to chat more at your convenience.

Sure sounds good, what’s the best way to contact you?

let's connect on twitter

There are, arguably, too many changes to really review here. But tests are passing, and skimming though I didn't see anything that looked obviously wrong. So, maybe the best course if just to do some more manual testing, and if all looks good after a bit, merge it into the 6.0 branch. I'll probably pull this down myself and test it out when i get a chance.