goldilocks

goldilocks copied to clipboard

I've deployed this to an OpenShift 4.6 cluster and if a pods limit/request comes from a LimitRange instead of being defined at the pod/deployment level it's current settings on the dashboard shows as "Not Set"

I converted this to a feature request. LimitRanges are not currently something we support.

Thanks, would it be a big change? Could you point me where in the current code base it would need to be added and I could maybe take a look.

I honestly don't know how hard it would be. I haven't used LimitRanges much at all.

Here is where we pull the current requests and limits - https://github.com/FairwindsOps/goldilocks/blob/a6988c29f15ff5472d147a4496dce76893d76d0f/pkg/summary/summary.go#L184-L190

Since it's based on the pod spec, I'm not sure how difficult it is going to be to bubble up the settings from the namespace-level object.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@MattPOlson We are looking for a similar solution. Is there any workaround if the limits are taken from Namespace limitranges ?