charts icon indicating copy to clipboard operation
charts copied to clipboard

[stable/goldilocks] Version Bumps, probe fix when base path set

Open lukerogers opened this issue 3 years ago • 1 comments

Why This PR?

  1. The base path functionality for #185 hasn't been released yet, this assumed it will go out in 4.3.4, so this shouldn't be merged until then
  2. The path to the probe was incorrect (my bad), this fixes previous PR #828

Changes Changes proposed in this pull request: *Add logic to ensure the base path has correct formatting for health probe

Checklist:

  • [ X ] I have included the name of the chart in the title of this PR in square brackets i.e. [stable/goldilocks].
  • [ X ] I have updated the chart version in Chart.yaml following Semantic Versioning.
  • [ X ] Any new values are backwards compatible and/or have sensible default.
  • [ X ] Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

lukerogers avatar Jul 16 '22 15:07 lukerogers

My apologies @lukerogers , I completely missed this and may have actually fixed in another PR. It does seem like your implementation may better though, so if you're willing to rebase, I think we can get your contribution in.

sudermanjr avatar Aug 10 '22 19:08 sudermanjr