yarn icon indicating copy to clipboard operation
yarn copied to clipboard

Add project icon to README

Open haykam821 opened this issue 3 years ago • 11 comments

haykam821 avatar Jan 14 '22 21:01 haykam821

Doesnt look so great here: https://github.com/haykam821/yarn/tree/readme-project-icon

modmuss50 avatar Jan 14 '22 21:01 modmuss50

can you change the image based on light/dark?…

frqnny avatar Jan 14 '22 22:01 frqnny

Is this image good license-wise? I am afraid.

Maybe add a width="25" in the img tag might help.

can you change the image based on light/dark?…

Yes. It's already transparent.

liach avatar Jan 15 '22 05:01 liach

🚀 Target branch has been updated to 1.18.2

github-actions[bot] avatar Mar 03 '22 03:03 github-actions[bot]

@haykam821 I see you have updated the branch on this so I assume you are still maintaining it? Are you able to fix it as its trival to merge once it works as expected.

modmuss50 avatar Mar 04 '22 13:03 modmuss50

@haykam821 What do you suggest to do with oversized icon? Put it as separate image on top or make it sized like a small icon in my suggestion?

liach avatar Apr 20 '22 12:04 liach

Do you still plan to fix this PR? If not I will close it.

modmuss50 avatar Jul 23 '22 14:07 modmuss50

Not sure if GitHub has changed their styling in the meantime, but IMO it looks fine now: image

NebelNidas avatar May 05 '23 16:05 NebelNidas

🚀 Target branch has been updated to 23w18a

github-actions[bot] avatar May 05 '23 16:05 github-actions[bot]

🚀 Target branch has been updated to 1.20-pre4

github-actions[bot] avatar May 21 '23 21:05 github-actions[bot]

🚨 Unable to automatically update branch with the latest changes

github-actions[bot] avatar May 21 '23 21:05 github-actions[bot]