process-compose icon indicating copy to clipboard operation
process-compose copied to clipboard

Expose method and expected status code on http checks

Open gkze opened this issue 2 years ago • 4 comments

gkze avatar Dec 22 '23 08:12 gkze

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 10 '24 08:01 sonarqubecloud[bot]

This branch has conflicts that must be resolved

@gkze would it be possible to find some time slot to handle conflicts? thank you

dzmitry-lahoda avatar Aug 24 '25 16:08 dzmitry-lahoda

Sorry for the long delay here. Yeah I can update this PR sometime by the end of this week.

gkze avatar Aug 25 '25 16:08 gkze

Just thinking about this - I realize my fork has fallen far enough behind that it might be worth restarting the change. I see that status code was already added.

For .ValidateAndSetDefaults(), if we add an Http field alongside the HttpGet field it would be possible to have a case where both are set. There is currently no error being returned from that method. Should the signature change to check that if both are set to return an error stating that those two fields are mutually exclusive?

gkze avatar Aug 30 '25 18:08 gkze