apipeline
apipeline copied to clipboard
Exilz
Feature/network first option
Hi @Exilz !
you lib is great!
I was trying to manage a real use case in the mobile world (and not only in it I guess): make a request perform a network first operation rather than check cache availability at the beginning of the flow. This will allow clients to try to refresh cache without altering the service definition, also because it wasn't possibile by defining any kind of middleware. This way clients are able to use the same service (then same cache) and by customising service options they can make the request behave accordingly to the above need.
Hope it makes sense.
Regards
Hi, thanks for the contribution.
This is something I thought about adding, too.
Could you make sure not to commit your .idea folder ? 😅 You can add it to the .gitignore as well.
Hi @Exilz,
I've removed the stuff you suggested, then updated the Readme and bumped the minor version. The PR is ready to be merged if you want.
Thanks for the code review @Villar74 . I added some comments, too. I wouldn't change anything on the generated javascript file. Let typescript do its thing.
Once you've made the requested changes, let's squash your commits before merging them.
Once you've made the requested changes, let's squash your commits before merging them.
@Exilz You talked to @mpatafio here?
Hi guys!
Thank you for the comments! I’ll fix them as soon as I’ll come back from holiday (likely 21st of August)
Hi guys! Thank you for the code review, I've resolved all the comments (apart the generated js files). Now I guess it can be merged. Just one thing for @Exilz: the image showing the flow of the library should be changed according to this new flow (conditioned by network first option), I changed the documentation, cannot do the same for such image. Thank you!