arcgis-rest-js icon indicating copy to clipboard operation
arcgis-rest-js copied to clipboard

Add job support

Open patrickarlt opened this issue 3 years ago • 4 comments

Enhancement of https://github.com/Esri/arcgis-rest-js/pull/1018 with additional doc and minor fixes.

patrickarlt avatar Sep 15 '22 19:09 patrickarlt

Codecov Report

Merging #1020 (aca4ab3) into main (135600c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main     #1020    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          141       146     +5     
  Lines         2653      2880   +227     
  Branches       492       519    +27     
==========================================
+ Hits          2653      2880   +227     
Impacted Files Coverage Δ
packages/arcgis-rest-request/src/index.ts 100.00% <100.00%> (ø)
packages/arcgis-rest-request/src/job.ts 100.00% <100.00%> (ø)
...ages/arcgis-rest-request/src/types/job-statuses.ts 100.00% <100.00%> (ø)
...es/arcgis-rest-request/src/utils/ArcGISJobError.ts 100.00% <100.00%> (ø)
...arcgis-rest-request/test/mocks/job-mock-fetches.ts 100.00% <100.00%> (ø)
...cgis-rest-request/test/utils/ArcGISRequestError.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 21 '22 17:09 codecov[bot]

@gavinr, The demo at the top of the file, you'll see that is parsing SECRET_KEY. However it needs to match whatever property you've called it, we must have missed it there it should read like:

const API_KEY = dotenv.config().parsed?.API_KEY;

marcysilverman avatar Sep 22 '22 15:09 marcysilverman

This is ready. @marcysilverman and I are having a meeting later today to debug some odd behavior we are seeing on sampleserver6.

patrickarlt avatar Sep 23 '22 16:09 patrickarlt

Now when I run npm start in demos/job, it opens a browser but I don't see anything about jobs. Am I supposed to see a Job being run here? image

gavinr avatar Sep 23 '22 21:09 gavinr

@gavinr want to take a look again?

patrickarlt avatar Sep 26 '22 21:09 patrickarlt