crystalorb icon indicating copy to clipboard operation
crystalorb copied to clipboard

Remove deref trait abuse

Open ErnWong opened this issue 4 years ago • 2 comments

E.g. https://github.com/ErnWong/crystalorb/blob/61590182c49c4dee25b7834de57aecd777b99e0d/src/timestamp.rs#L261-L272

There are probably other cases.

ErnWong avatar Jun 08 '21 01:06 ErnWong

Is there a reasoning for it? (besides it is seen as bad practice)

smokku avatar Jun 19 '21 09:06 smokku

Not really. It's not really blocking any particular use-case or causing any headaches (yet), but it might be good to get the semantics "right".

ErnWong avatar Jun 19 '21 09:06 ErnWong