EpikCord.py

EpikCord.py copied to clipboard

Code isn't looking the cleanest, clean it up before 1.0 otherwise you'll be made fun of ;( .

Hi, I'm looking to contribute. How can I help?

Hi there! Thanks for trying to help. So basically, take a look at the file system, it doesn't look the cleanest in my eyes. If you have any suggestions on how I could make it look better, just let me know, and if you're feeling really really helpful, just open a pull request. Thanks again

Hey, I was unsure about the specific roles of each file. The file names weren't really helpful to be honest. But how about this folder structure? Separating them into their folders based on use case and those that don't fit in can be thrown into commons. It'd be great if we could rename ws.py to websocket.py and have a more meaningful name for abc.py

abc.py could be called abstract.py

I could do a file system where each "Topic" according to the Discord API Docs, has it's own folder? Or I can just easily just separate them by a certain thing they all have in common.

Doesn't sound like too bad of an idea, iirc VSC has the automatic refactoring stuff so it should automatically update the imports once you move the stuff around

It does, the main priority now is for the login func to work.

Looks good to me.

Cleanup of consistency of typehints is also needed

isn't this pretty much sorted?

I'll probably get you, Juuzou and I to do some checks, like seeing if theres anything to be improved. If we can't think of any, we'll close this issue. Probably after #193 though

Why was this added to the "100% coverage of the Discord API" milestone? Cleaner code isn't related to implementing all of the Discord API

no clue

Why was this added to the "100% coverage of the Discord API" milestone? Cleaner code isn't related to implementing all of the Discord API

@TheUntraceable

Good point, I blindly just added all issues to the milestone