cardano-serialization-lib icon indicating copy to clipboard operation
cardano-serialization-lib copied to clipboard

Published 20 hours ago • verified publisher icon Emurgo

Add Witness builder

Open SebastienGllmt opened this issue 3 years ago • 3 comments

The problem with TransactionWitnessSet is that at the protocol level it should be a set, but at the CDDL level it's just a list. This means it's up to individual implementations to de-duplication which is not ideal.

This PR adds a TransactionWitnessSetBuilder which handles the deduplication for you. It's a first step to #37 and can also help with #273

SebastienGllmt avatar Dec 25 '21 01:12 SebastienGllmt

I went ahead and also added a RequiredWitnessSet so that the tx builder can pass information about which witnesses are required. I didn't hook it up to the tx builder since probably it would conflict with #273 too much

SebastienGllmt avatar Dec 25 '21 16:12 SebastienGllmt

This is important. Wen?

nicolasayotte avatar Sep 22 '22 02:09 nicolasayotte

Would it be possible to add functionality to combine two TransactionWitnessSet?

jonathangenlambda avatar Mar 22 '23 09:03 jonathangenlambda