erpc icon indicating copy to clipboard operation
erpc copied to clipboard

[BUG] Comments and whitespace changes in IDL affect generated CRC

Open berendo opened this issue 2 years ago • 0 comments

Describe the bug Making whitespace changes or comment text changes in an IDL affects the auto-generated CRC calculation. This is because the expected CRC is calculated without regard to the lexer/parser tokens, just as a plain CRC of the file read via istreambuf here.

To Reproduce Make any non-code-generation-significant change such as altering whitespace or editing comments in an IDL and observe that the generated client cannot issue an RPC to a previously-generated server.

Expected behavior Whitespace and comment changes should not alter the CRC. Only IDL tokens that are significant to the operation of the RPCs such as function signature, types, attributes, etc. should influence the CRC.

Screenshots N/A

Desktop (please complete the following information): N/A

Steps you didn't forgot to do

  • [x] I checked if there is no related issue opened/closed.
  • [x] I checked that there doesn't exist opened PR which is solving this issue.

Additional context N/A

berendo avatar Apr 28 '23 13:04 berendo