Nick Chapsas
Nick Chapsas
You might need to re register it?
@Tayran Returning a ResultSet is wrong. You should return a list or a single entry of the entity itself, and not the ResultSet. It has no reason to be anywhere...
Does it actually fix the logs?
Did you test it?
Cool i will take a look when i get home unless @LeonanCarvalho can test it before me
We need a rule. Any Pull request that is not tested by whoever is creating it will be closed immediately. Yes we need testers but doing pull requests for untested...
@queued I didn't test it. That's my point. I don't know if it works and you don't know if it works. You should no that it works because you should...
You should also consider changing the DB Pool to use HikariCP as it is WAY faster than c3p0.
@LeonanCarvalho L2jServer uses it. I also used it on live L2 server. The biggest difference can be noticed when you change subclass. Normally player freezes for 2-3 seconds on acis...
@Tayran I will have a go on it on a fork and do a pull request if i get it working.