eRCaGuy_TimerCounter icon indicating copy to clipboard operation
eRCaGuy_TimerCounter copied to clipboard

Remove unused class member _total_count

Open edgar-bonet opened this issue 5 years ago • 1 comments

This member was only used in the get_count() method, right after being set. Making it a local variable of get_count() makes the class 40% smaller and the method slightly faster. It also speeds-up the constructor and the reset() method.

edgar-bonet avatar Jul 28 '20 13:07 edgar-bonet

Thanks for looking at the library! I'll take a look at this when able. See also my comment here: https://github.com/ElectricRCAircraftGuy/eRCaGuy_TimerCounter/pull/8#issuecomment-665187087. I'd like to do a major re-look at this library before merging PRs, as I've grown a lot since I first wrote it.

ElectricRCAircraftGuy avatar Jul 28 '20 18:07 ElectricRCAircraftGuy