io
io copied to clipboard
Effect-TS
add serviceEffects and change serviceConstants semantic (fixes #634)
🦋 Changeset detected
Latest commit: 48df8f49d7e6e8379aa04b793b9fe1cb85b4a760
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @effect/io | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Not really if we keep the functions and effect returning functions separated
On Fri, 15 Sept 2023, 17:10 Tim, @.***> wrote:
@.**** commented on this pull request.
In src/internal/effect.ts https://github.com/Effect-TS/io/pull/659#discussion_r1327434432:
@@ -1842,6 +1842,24 @@ export const serviceFunctions = <I, S>( /** @internal */ export const serviceConstants = <I, S>(
for example the return value is an option or an effect that shouldn't be flattened
I think this is already an issue due to the type augmentation.
— Reply to this email directly, view it on GitHub https://github.com/Effect-TS/io/pull/659#discussion_r1327434432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZAKCTB4LATB32A6LGOCKDX2RVWTANCNFSM6AAAAAA4QJ3CRA . You are receiving this because you commented.Message ID: @.***>
