effect icon indicating copy to clipboard operation
effect copied to clipboard

refactor: deduplicate schema optional types

Open vinassefranche opened this issue 1 year ago • 1 comments

Type

  • [x] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

Followup of this comment on a previous P.R.

I did not add any changeset as it's supposed to be an internal refactor but, as shown in the update of the types' tests, there's a small potential external change so tell me if you think I should add one.

Related

  • Related Issue #
  • Closes #

vinassefranche avatar May 20 '24 19:05 vinassefranche

⚠️ No Changeset found

Latest commit: 8c7702100d207466b05b6700e7b49c2213fe5995

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 20 '24 19:05 changeset-bot[bot]

Closing in favour of https://github.com/Effect-TS/effect/pull/2794

gcanti avatar May 21 '24 09:05 gcanti