kernl icon indicating copy to clipboard operation
kernl copied to clipboard

Published 20 hours ago • verified publisher icon ELS-RD

add `tl.math.tanh` instead of `tl.libdevice.tanh`

Open michaelfeil opened this issue 1 year ago • 2 comments

Seems like tanh moved to a

see triton/language/math.py-L1238

@core.extern
def tanh(arg0, _builder=None):
    return core.extern_elementwise(
        "libdevice", libdevice_path(), [arg0], {
            (core.dtype("fp32"), ): ("__nv_tanhf", core.dtype("fp32")),
            (core.dtype("fp64"), ): ("__nv_tanh", core.dtype("fp64")),
        }, is_pure=True, _builder=_builder)

michaelfeil avatar Feb 16 '24 00:02 michaelfeil

@pommedeterresautee FYI, unit tests seem to pass. What do you think about this PR?

michaelfeil avatar Feb 18 '24 00:02 michaelfeil

@pommedeterresautee friendly reminder!

michaelfeil avatar Mar 09 '24 02:03 michaelfeil