OLS icon indicating copy to clipboard operation
OLS copied to clipboard

jstree api call returning an empty list

Open srobb1 opened this issue 6 years ago • 1 comments

Hello,

Should the jstree api call be returning any empty list [] ?

https://www.ebi.ac.uk/ols/api/ontologies/go/terms/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FGO_0043226/jstree

I am trying to use the OLS-treeview but a tree that used to work on my site is no longer working and the examples 1 and 2 in the OLS-treeview repo are not working. I see that there is a jstree api call, and it is returning []. Is this why my tree is not being drawn? Has something happened to jstree?

Thank you, Sofia

srobb1 avatar Mar 23 '20 17:03 srobb1

A colleague (Eric Ross) and I figured out that viewMode=All and siblings=true/false is now required by the jstree api call.

https://www.ebi.ac.uk/ols/api/ontologies/go/terms/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FGO_0043226/jstree

vs

https://www.ebi.ac.uk/ols/api/ontologies/go/terms/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FGO_0043226/jstree?viewMode=All&siblings=true

This should be addressed in some code used by OLS. For example the 'json' generator on term pages produces a linkout in the result to jstree which is malformed.

We generated a fix in the OLS-treeview repo: https://github.com/EBISPOT/OLS-treeview/pull/10

Thanks, Sofia

srobb1 avatar Mar 23 '20 22:03 srobb1