Telegram icon indicating copy to clipboard operation
Telegram copied to clipboard

Fix icon on Samsung Galaxy devices

Open fonix232 opened this issue 7 years ago • 4 comments

The line I removed from the manifest makes it possible for the Samsung Galaxy framework to style the icon (adaptive icons, before adaptive icons were even a thing). This will add a colored "squircle" background, allowing Telegram to blend in.

I understand that many do not like the old, Note7 style "bland" icon, but this way the icon stands out too much from the rest of the apps. Also, so far it was Telegram (and clones) only that have employed this tactic, most likely by this "fix recommendation" - a.k.a. how to fuck up your app icon aesthetics on Samsung devices.

Unless the Telegram icon is changed to a Samsung-matching squircle style one, I think the best course of action would be removing this flag from the manifest.

fonix232 avatar Feb 27 '18 08:02 fonix232

Is anyone going to merge this change? Its a line removal, and Telegram X has already fixed this issue. Is there any reason that this pull request won't be merged?

parker-michael avatar Aug 29 '18 21:08 parker-michael

Lmao, 2 years nearly and still not merged or solved...

divadsn avatar Jan 14 '20 17:01 divadsn

Well, it's been solved, as the problematic metadata flag has been removed.

What I don't understand is why this ticket was never responded to, if it was a duplicate, why wasn't it marked as such, and since the issue has been fixed, why wasn't it closed?

On Tue, 14 Jan 2020, 17:13 David Sn, [email protected] wrote:

Lmao, 2 years nearly and still not merged or solved...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DrKLO/Telegram/pull/1465?email_source=notifications&email_token=AAC2ZBYQ6ZKTSKIJTAKLE63Q5XXCXA5CNFSM4ESSGG4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI5M2YQ#issuecomment-574279010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2ZB2R2X6CMKDKWCRVS7LQ5XXCXANCNFSM4ESSGG4A .

fonix232 avatar Jan 14 '20 17:01 fonix232

In case you haven't noticed, they don't respond to PRs or issue or anything. This is merely a source dump so they can say Telegram is FOSS

androidacy-user avatar Jan 14 '20 17:01 androidacy-user

I see this code was merged, thanks for the PR!

dkaraush avatar Mar 14 '24 12:03 dkaraush