Pablo Duboue

Results 43 comments of Pablo Duboue

Alright, do you want me to remove it from this PR?

Nothing in particular. It was already present in the code and it is in the example TSV linked in #1861.

Let me know if you want the commits to be squashed. (I do hope font information can be brought back into the engine in some moment.)

> Yes. > > What is a use case for `lang_info`? Sorry, I misunderstood your question. The use case for `lang_info` (not for the font information) is in #1861.

Thanks for the warm comments. My answers below: > This looks great! I will try to review it ASAP. > > Initial comments: > > 1. I see that you...

> Is it really necessary to inherit from HTML Gen? Probably it will be more logical to extract some common parts to a new base class? I hear you. I...

Hi! Glad to see you're making progress on Adventure. Is there any problem with this patch? I like your project and would like to contribute to it.

This patch looks very good. Any chances @sameersingh might consider moving the project to a team maintenance? Scalaplot is a great tool and there is enough interest in the community...