Donnerbart

Results 35 comments of Donnerbart

We still face this issue. Can someone _please_ have a look at #6119 to get this fixed?

I'm happy to rebase my pending PR _if_ someone will finally review it. We also have workarounds in place for this, that I'd really like to get rid of.

I gave it a try this morning and came up with this method, that I call at the beginning of our `desired()` method: ```java private final @NotNull Set labelAndSelectorCheckDone =...

**com.hazelcast.map.impl.nearcache.invalidation.MemberMapReconciliationTest.test_reconciliation_does_not_cause_premature_removal[mapInMemoryFormat:OBJECT nearCacheInMemoryFormat:OBJECT]** ```java java.lang.AssertionError: Wrong expectedHits [NearCacheStatsImpl{ownedEntryCount=100, ownedEntryMemoryCost=0, creationTime=1511974070623, hits=96, misses=104, ratio=92.3%, evictions=0, expirations=0, lastPersistenceTime=0, persistenceCount=0, lastPersistenceDuration=0, lastPersistenceWrittenBytes=0, lastPersistenceKeyCount=0, lastPersistenceFailure=''}] expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at...

**com.hazelcast.map.impl.nearcache.invalidation.MemberMapReconciliationTest.test_reconciliation_does_not_cause_premature_removal[mapInMemoryFormat:OBJECT nearCacheInMemoryFormat:OBJECT]** ```java java.lang.AssertionError: Wrong expectedHits [NearCacheStatsImpl{ownedEntryCount=100, ownedEntryMemoryCost=0, creationTime=1519848266317, hits=98, misses=102, ratio=96.1%, evictions=0, expirations=0, lastPersistenceTime=0, persistenceCount=0, lastPersistenceDuration=0, lastPersistenceWrittenBytes=0, lastPersistenceKeyCount=0, lastPersistenceFailure=''}] expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at...

There was a test failure in the [Windows Build / Java 17 Maven](https://github.com/fabric8io/kubernetes-client/actions/runs/12015803082/job/33494640137?pr=6663) `LeaderElectorTest.jitterWithPositiveShouldReturnPositiveDouble:338 expected: but was: ` which looks unrelated to my changes. Is this a known flaky test?...

I've removed the changelog entry (just saw a similar one in a previous release). @manusa Could you give me one concrete example how you would like the asserts to look...

We would also have a use-case to customize this matcher. I didn't implement this yet in our project, we still use some copied code from the `GenericKubernetesResourceMatcher`, but this is...

I'm just playing around with this a little and we would actually need access to the primary resource. Not sure if we would need access to the raw actual and...

The patched `SSABasedGenericKubernetesResourceMatcher` from my last comment works fine for our use-case. The biggest issue is unit testing though. We run into the same problem like `SSABasedGenericKubernetesResourceMatcherTest` in this repo:...