ACadSharp icon indicating copy to clipboard operation
ACadSharp copied to clipboard

Revert Text/MText Linking of Rotation and AlignmentPoint

Open DJGosnell opened this issue 2 years ago • 2 comments

While testing these changes in production, it was found that since the MText.Rotation set the AlignmentPoint and vice versa, the former would break the correct alignment points which are required for correct text placement.

This PR reverts part of the changes relating to the linking of Rotation and AlignmentPoint for both TextEntity and MText.

We need to review how to handle this properly. Right now, I think the best course of action would be to unlink the two and allow for the library consumer to determine how to properly handle the values. I am not even sure that it is actually possible to convert from a Rotation radian to a 3D AlignmentPoint.

DJGosnell avatar Dec 14 '22 17:12 DJGosnell

Side note, do you have any more direct contact you use? Email, Discord, etc.? I'd love to be able to talk about certain parts of this project more in a conversational environment if you would be willing.

DJGosnell avatar Dec 14 '22 17:12 DJGosnell

I've opened the discussions in Github

DomCR avatar Dec 15 '22 12:12 DomCR

Closing old PR.

DJGosnell avatar Apr 22 '24 16:04 DJGosnell