materialize icon indicating copy to clipboard operation
materialize copied to clipboard

Move calls to color() to _variables.scss

Open brianlmoon opened this issue 7 years ago • 2 comments

Fix #5608

Proposed changes

The divider color in _global.scss and the badge text color in _badges.scss is using a direct call to color() function. By moving these colors to _variables.scss, it allows for users to override $colors and any color variables in _variables.scss before importing those files.

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue).
  • [ ] New feature (non-breaking change which adds functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [X] I have read the CONTRIBUTING document.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [X] All new and existing tests passed. (the tests for Optgroup Select do not currently pass for the v1-dev branch)

brianlmoon avatar Jan 26 '18 21:01 brianlmoon

These are the only two I have find outside of _variables.scss. There is a file _style.scss in the sass directory that has some calls in it. But, it is not used to build materialize.css. I am not sure of its purpose.

brianlmoon avatar Jan 30 '18 14:01 brianlmoon

Any chances of getting this merged into v1-dev? I am maintaining our fork, but would prefer to use an official release.

brianlmoon avatar Feb 28 '18 06:02 brianlmoon