node-steamcommunity icon indicating copy to clipboard operation
node-steamcommunity copied to clipboard

Re-enable primaryGroup profile setting

Open 3urobeat opened this issue 3 years ago • 2 comments

Hey!
The primaryGroup setting in the editProfile() function does seem to work again so I decided to open a PR that enables the code block again.

I've tested the function with a limited and an unlimited account. The limited acc has E-Mail steam guard, the unlimited acc is secured with mobile steam guard.

I called the function like this from the webSession event to make sure cookies were set:

const SteamID = require("steamid")

community.editProfile({ //community was set previously as a new SteamCommunity object
    primaryGroup: new SteamID("my_groupID64")
}, (err) => {
    if (err) console.log(err);
})

 

This successfully updated my primaryGroup setting.
I also tested the other two disabled settings (background & featuredBadge) but was unable to get them to work as well :(

3urobeat avatar Jun 03 '22 10:06 3urobeat

Oh and while you are here - one question:
Is there something holding you back from updating the dependencies? async, image-size, node-bignumber, steam-totp, steamid and xml2js are all out of date (and async seems to have a security vulnerability).

3urobeat avatar Jun 03 '22 13:06 3urobeat

Oh and while you are here - one question: Is there something holding you back from updating the dependencies? async, image-size, node-bignumber, steam-totp, steamid and xml2js are all out of date (and async seems to have a security vulnerability).

he's busy with a major rewrite (v4), which is taking a long time...

Revadike avatar Jun 03 '22 14:06 Revadike

Closing this PR because I added more commits to my master branch. Transferred to #307.

3urobeat avatar May 14 '23 15:05 3urobeat