node-steam-user

node-steam-user copied to clipboard

• [x] Allow pics cache to be saved to disk (https://github.com/DoctorMcKay/node-steam-user/issues/188)
• [x] Read (and sync) saved pics cache to reduce requesting productinfos (https://github.com/DoctorMcKay/node-steam-user/issues/385)
• [x] Refactor code and reduce complexity of getProductInfo() (comments 1 2)
• [x] Request product info in bulk (and save progress in between).
• ~~Request missing tokens by default? (discussion)~~
• [x] Use meta_data_only instead of tracking changenumber (reason: changenumber changes can be only requested until a certain point)
• [x] Fix README.md

@DoctorMcKay early feedback is welcome and encouraged!

Request missing tokens by default?

It does make sense to request missing tokens by default, but this would be a breaking change so it's best not to.

Request missing tokens by default?

It does make sense to request missing tokens by default, but this would be a breaking change so it's best not to.

Hmm, I'm thinking, maybe just like the global ownershipFilter, the same can be done by globally setting this behavior too.

Hmm, I'm thinking, maybe just like the global ownershipFilter, the same can be done by globally setting this behavior too.

Ehh, I'm not a big fan of adding a new global option just to avoid having to type true a few times. A global ownership filter makes sense because it affects many different methods and is a complex data type, but a simple bool isn't a burden to type.

Fair enough

It should work as-is, but for this PR to work better, I highly suggest merging this PR (and potentially this PR) as well.

New TODO:

• [x] Use meta_data_only instead of tracking changenumber (reason: changenumber changes can be only requested until a certain point)

New TODO:

• [x] Fix README.md

Bug found: requesting product info of subids/appids as string results in deadlock.

Edit: Or maybe not? :S

Ready to merge?