flame_on icon indicating copy to clipboard operation
flame_on copied to clipboard

PhoenixLiveView 0.19 & PhoenixLiveDashboard 0.8 breaking changes

Open JosePamplona opened this issue 2 years ago • 1 comments

After the yesterday's update to the Phoenix Live View and Phoenix Live Dashboard repositories, there is an issue when Flame On is compiled as a dependency in a project that utilizes the most recent versions of those repositories. This issue results in an error that halts the compilation process:

==> flame_on
Compiling 13 files (.ex)
warning: got "@impl Phoenix.LiveDashboard.PageBuilder" for function render_page/1 but this behaviour does not specify such callback. The known callbacks are:

  * Phoenix.LiveDashboard.PageBuilder.handle_event/3 (function)
  * Phoenix.LiveDashboard.PageBuilder.handle_info/2 (function)
  * Phoenix.LiveDashboard.PageBuilder.handle_params/3 (function)
  * Phoenix.LiveDashboard.PageBuilder.handle_refresh/1 (function)
  * Phoenix.LiveDashboard.PageBuilder.init/1 (function)
  * Phoenix.LiveDashboard.PageBuilder.menu_link/2 (function)
  * Phoenix.LiveDashboard.PageBuilder.mount/3 (function)
  * Phoenix.LiveDashboard.PageBuilder.render/1 (function)

  lib/flame_on/dashboard_page.ex:12: FlameOn.DashboardPage (module)

warning: function render/1 required by behaviour Phoenix.LiveDashboard.PageBuilder is not implemented (in module FlameOn.DashboardPage)
Warning:   lib/flame_on/dashboard_page.ex:1: FlameOn.DashboardPage (module)

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:114: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:115: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:116: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:117: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:119: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:120: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:121: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:123: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:124: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:125: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:127: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:128: FlameOn.Component.render/1

warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
Warning:   lib/flame_on/component.html.heex:129: FlameOn.Component.render/1

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:129

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:128

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:127

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:125

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:124

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:123

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:121

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:120

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:119

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:117

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:116

warning: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)
Warning:   lib/flame_on/component.html.heex:115


== Compilation error in file lib/flame_on/component.ex ==
Error: ** (CompileError) lib/flame_on/component.html.heex:114: undefined function f/0 (expected FlameOn.Component to define such a function or for it to be imported, but none are available)

could not compile dependency :flame_on, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile flame_on", update it with "mix deps.update flame_on" or clean it with "mix deps.clean flame_on"
Error: Process completed with exit code 1.

In order to successfully compile the project, it is required to downgrade the versions of the Phoenix repositories to "0.18.18" for Phoenix Live View and "0.7.2" for Phoenix Live Dashboard.

JosePamplona avatar Jun 01 '23 01:06 JosePamplona

This PR should tackle this issue

https://github.com/DockYard/flame_on/pull/33

image

filipecabaco avatar Jun 15 '23 22:06 filipecabaco

@JosePamplona Closing this as the above PR should have resolved the issue. If it didn't, feel free to submit a new issue with the latest details.

TheFirstAvenger avatar Jun 10 '24 12:06 TheFirstAvenger