Dimitar Krastev

PcapLiveDevice stores IP addresses in structured that may be overwritten.

2

During initialization of `PcapLiveDeviceList` information of all devices is fetched via `pcap_findalldevs`. This information is used to populate `PcapLiveDevice` objects and then the list is freed. This results in an...

This is an issue to track progress that will be done over several PRs. Task overview: 1. - [x] Refactor `PcapLiveDeviceList` to use smart pointers internally for memory management. 2....

PcapRemoteDevice's clone method does not work.

4

`PcapRemoteDevice`'s clone method directly inherits from `PcapLiveDevice`'s clone method. The method incorrectly attempts to fetch the device from local devices, failing and returning `nullptr`. Solution would be to add an...

Logger overhaul.

1

Overhaul of the built-in logging infrastructure. Removed exposed internals of Logger and added new `log` functions to serve as intermediaries. The new system is about as fast as the old...

Wrap `timespec` <-> `timeval` conversion in helpers.

1

This PR adds helper functions `toTimespec` and `toTimeval` to encapsulate conversion logic. The helpers are defined in `TimespecTimeval.h` and are expected to be in inlined when optimizations are enabled.

Extracted MTU check code into its own helper functions.

1

This PR separates the logic for checking packets against the device MTU size by moving validation code to `checkMtu` helper functions. It also renames `sendPacketDirect` to `sendPacketUnchecked` to improve readability.

Added guard clause to `stopCapture` to prevent incomplete shutdown.

1

This PR adds a guard clause to `stopCapture` to raise an exception if the method has been called from the thread executing the background capture, as doing so would produce...

Cleanup of `PcapLiveDevice` capture machinery.

1

This PR moves the implementation of the capture procedures to internally linked functions in `PcapLiveDevice.cpp` and aims to reduce the the need for extensive bookkeeping of capture thread only variables....

Attempt to flatten the `BgpLayer` inheritance chain.

6

## Overview This PR is a draft attempt to flatten the inheritance chain of `BgpLayer` and separate the protocol layer parsing logic from the message payload parsing logic. In the...

Refactor reentrant flag to be set during channel creation.

4

Split of #1668 This PR aims to standardize `m_ReentrantMode` to be set during the channel opening phase instead of the capture initialization phase as it is determined by the opening...