Doug Roeper

Results 25 comments of Doug Roeper
trafficstars

OK, did a bit of debugging. Here's what I did: I ran the tests locally: ``` bazel test //...:all # Picked the first failing test in the output and ran...

Yes, I think the problem is that we can't resolve the timestamp proto JS code. There are two place we can potentially fetch the code from: 1. Since this is...

Yeah, I'm fine with some hard coding if you want to do option 2. Just leave a comment with a reference to the `js_generator` code where the package name is...

Thanks @pfgallagher - If you could submit a PR that would be awesome. #11 seems to be stale.

Thanks for reporting this issue and creating a test case for it. I did some debugging and I've been able to get rid of the rollup errors by changing `namedExports`...

Good find! You're correct, `var grpc = require("@improbable-eng/grpc-web").grpc;` is not equivalent to `import * as grpc from "@improbable-eng/grpc-web";` Overall PR looks good, once we get the tests fixed it should...

Hi @jozsbs, Unfortunately I'm not familiar with webpack so I don't know why it's not resolving the dependency. We have an example of using rollup [here](https://github.com/Dig-Doug/rules_typescript_proto/blob/master/test/BUILD.bazel#L161) which is able to...

There are two main parts to the current bazel setup: 1. Rules needed to build the protoc plugins under bazel, e.g. [this target](https://github.com/improbable-eng/ts-protoc-gen/blob/master/bin/BUILD.bazel#L5) 2. Rules for generating typescript definitions and...