IronRDP icon indicating copy to clipboard operation
IronRDP copied to clipboard

Is "arbitrary" actually used?

Open elmarco opened this issue 1 year ago • 3 comments

cargo build --features arbitrary fails currently. And it seems to not be covered by CI.

I am not familiar with that crate, but it seems there are no actual code using it inside IronRDP.

Can we drop it?

elmarco avatar Feb 12 '24 08:02 elmarco

It’s not yet used, but the intention is to use it for more advanced fuzzing.

CBenoit avatar Feb 12 '24 13:02 CBenoit

Do you see the build failure too? I don't know why, it seems to have appeared recently (perhaps a rust upgrade?)

elmarco avatar Feb 12 '24 13:02 elmarco

I got it too. We probably broke it because it’s not checked in the CI yet. But it’s probably not too hard to fix and we can do that when actually moving forward the fuzzing effort. It’s okay to leave it as-it for now. (Worse case I’ll document the feature as unstable when we publish the crate if it’s still not usable.)

CBenoit avatar Feb 12 '24 14:02 CBenoit