AdvancedBan icon indicating copy to clipboard operation
AdvancedBan copied to clipboard

Published 20 hours ago • verified publisher icon DevLeoko

Add CloudnetV4 support and maven depedency fix

Open Phyrone opened this issue 2 years ago • 5 comments

  • kick player using cloudnet v4 instant of bungeecord (like version 3 and 2 support)
    • fix player not kicked when using cloudnet v4
  • updated maven dependencies necessary to compile

CloudnetV4 is at the moment of this pull request still in release candidate state. It's still possible that the API changes, however I consider it as very unlikely.

Phyrone avatar Jan 04 '23 16:01 Phyrone

Looks good - has this been tested with the latest CloudNet V4 build?

DevLeoko avatar Jan 04 '23 18:01 DevLeoko

I installed it on my network(which is v4 - rc5) for a few hours now, and it works fine so far.

Phyrone avatar Jan 04 '23 22:01 Phyrone

However cloudnet v4 uses adventure text, and I was not sure first, how to convert. I used legacy next convert for (like bungeecord TextComponent.fromLeagytext) now. I think that's the correct one.

Phyrone avatar Jan 04 '23 22:01 Phyrone

Seems like something with the Cloudnet V4 dependency is wrong (see automated test)

DevLeoko avatar Jan 07 '23 13:01 DevLeoko

Looks like cloudnet 4 requires at least java 17 meanwhile advancedbans still compiles on java 1.8. i dont know how to solve this without upgrading advancedbans to java 17

Phyrone avatar Jan 07 '23 13:01 Phyrone