AdvancedBan icon indicating copy to clipboard operation
AdvancedBan copied to clipboard

isSilent boolean

Open BlueTree242 opened this issue 5 years ago • 5 comments

AB version: 2.2.1

Server Software: Paper

Server version: 1.16.3

Hello, i would like to suggest adding isSilent boolean, when player is banned by an operator we can add -s to hide the ban.

BlueTree242 avatar Oct 06 '20 19:10 BlueTree242

Not sure if that's a good idea. isSilent is not really a property of a punishment but just the way it gets executed. So it should not be stored in the punishment class. But I will leave this issue open for discussion or other opinions

DevLeoko avatar Oct 06 '20 20:10 DevLeoko

Not sure if that's a good idea. isSilent is not really a property of a punishment but just the way it gets executed. So it should not be stored in the punishment class. But I will leave this issue open for discussion or other opinions

I just making an addon where it prints bans to discordsrv's general channel, but if punishment is silent I don't want it to print

BlueTree242 avatar Oct 06 '20 20:10 BlueTree242

Maybe you can add it in the next version, adding isSilent to the database.

BlueTree242 avatar Oct 07 '20 00:10 BlueTree242

Implementing a silent field into the database would need some kind of converting i think. Otherwise getting the silent status from old punishments that would've been created before implementing it would cause issues.

Hopefuls avatar Oct 07 '20 11:10 Hopefuls

PLEASE ADD IT

BlueTree242 avatar Oct 29 '20 19:10 BlueTree242