dependency-track icon indicating copy to clipboard operation
dependency-track copied to clipboard

add jira and gchat integration classes, variables and tests

Open elastic-pangolin opened this issue 3 years ago • 2 comments
trafficstars

additions as promised in Issue #1583

elastic-pangolin avatar May 16 '22 11:05 elastic-pangolin

Hi @elastic-pangolin, are you still interested in getting this merged?

nscuro avatar Aug 12 '22 12:08 nscuro

Hi @elastic-pangolin, are you still interested in getting this merged?

Hello @nscuro , thank you for checking in with me. I was very busy, but I am currently able to invest some more time. Working on your last change requests, I'm still very interested in getting Jira tickets into the project.

elastic-pangolin avatar Sep 06 '22 14:09 elastic-pangolin

:warning: 14 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift[bot] avatar Oct 04 '22 08:10 sonatype-lift[bot]

Hi everyone, I think I am finished but unfortunately my repo seems to be corrupted...

Find attached the last patch removing my testing comments 0001-removed-testing-relics-and-comments.patch.txt

elastic-pangolin avatar Nov 04 '22 15:11 elastic-pangolin

hi @elastic-pangolin, since this PR seemed stalled for a few months and is still pending change requests, I took the liberty to create another PR that specifically targets the jira integration functionality.

I am available to respond quickly to requests or comments made by maintainers, and make sure it is added quickly to the codebase.

I would also of course welcome any suggestions/improvements you might have yourself concerning this topic (things you thought of adding but didn't have time to).

I want to contribute as much as possible to have this feature integrated in 4.7.0. Do you mind if I take over this feature ?

Mvld3r avatar Nov 08 '22 15:11 Mvld3r

Hi @Mvld3r , that's great! You go ahead and take this over. I am myself not well versed with atlassian jira, but another request I got was to be able to configure a default assignee. I'll have a look at your PR and do some testing.

Thanks again to everyone for supporting the jira integration, it's really important for us!

elastic-pangolin avatar Nov 18 '22 13:11 elastic-pangolin

Thanks for your response! My PR was approved by @nscuro yesterday so I believe it will ship in the next release.

I want to bring to your attention that my PR doesn't target the gchat integration (which is not something I need), so if this is something you're interested in, you can proceed on that sub-feature.

Regarding the default assignee, I think there are multiple options available for you, all of which work with my current PR:

  • set a default assignee at the jira project level
  • set an assignee with jira automation based on some criteria (such as the ticket title)
  • set a assignee in the dtrack template notification, which can be overridden (it requires looking at the jira API)

It would be great if you could do some testing with my PR and report back if it fits your needs and works as intended, as I'm not sure code review implies testing.

Mvld3r avatar Nov 19 '22 17:11 Mvld3r

@elastic-pangolin, as you might have noticed, Dependency-Track v4.7.0 has now shipped... and does contain a JIRA integration.

So, have you had a chance to try it, and does it meet your needs?

msymons avatar Dec 20 '22 15:12 msymons

Closing as Jira support was shipped in 4.7.

@elastic-pangolin, @Mvld3r thank you both for your efforts, it's much appreciated.

@elastic-pangolin, we'd love to have Google Chat integration. If you'd still like to contribute that, I'd ask you to raise a new PR for it. Thanks again!

nscuro avatar Jan 27 '23 17:01 nscuro