table2ascii
table2ascii copied to clipboard
DenverCoder1
Broken/lacking metadata in latest versions (1.1.0 and 1.1.1)
Encountering following issues with latest versions (1.1.0 and 1.1.1) of table2ascii:
WARNING: Generating metadata for package table2ascii produced metadata for project name unknown. Fix your #egg=table2ascii fragments.
<package source link> has inconsistent name: filename has 'table2ascii', but metadata has 'unknown'
Presumably caused by the lack of the name and version parameters in the setup.py, considering those are there in the previous working version 1.0.4. I have also manually fixed this exact issue with some other packages in the past by editing that information into the setup.py and installing via that updated local package, so all things considered seems like a likely (and easy) fix.
Worth a note that all worked fine on my local machine for whatever reason; the issue presented itself only when I deployed it to my remote pipeline, but that's probably just to do with differing environments (particularly pip, because the new stricter pip versions are likely the cause of this).
It would be sweet to have a fix for this in any case, because while there are great many workarounds you can do manually, those defeat the point of being able to cleanly automate pip environment via requirements.txt and some scripting.
Yeah, I believe it is an issue with older versions of pip. I had been switching things to use modern techniques but unfortunately this makes it incompatible with some deployments.
I wrote a fix a couple months ago in #105 but it was not merged yet.
https://github.com/DenverCoder1/table2ascii/compare/main...name-and-version-in-setup
https://github.com/DenverCoder1/table2ascii/pull/109/files
I suppose it can be merged now, feel free to review it and let me know if it looks good to you.
While I can't properly verify the functionality in the original situation before the release, the code changes themselves look good to me.
Seems okay to go forward with this, approved.
I'll leave closing the issue to you when done with the process, cheers
v1.1.2 is released now. If there are still the same issues, let me know. I don't have a way of easily testing it currently.