DefinitelyTyped icon indicating copy to clipboard operation
DefinitelyTyped copied to clipboard

[react-relay] fix fetch policy to match Flowtype

Open koichik opened this issue 3 years ago • 4 comments

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/facebook/relay/blob/bd2e4173ef726804b2ed4e76d88a7bcc1753c496/packages/react-relay/relay-hooks/EntryPointTypes.flow.js#L41

koichik avatar Jul 09 '22 06:07 koichik

@koichik Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61159,
  "author": "koichik",
  "headCommitOid": "ca313b48a10080b0f666fbbd424dbf72c21708fe",
  "mergeBaseOid": "d13cccac3a0d9b9b3aad45ae2c306d079d63fdfb",
  "lastPushDate": "2022-07-09T05:56:47.000Z",
  "lastActivityDate": "2022-08-15T23:57:45.000Z",
  "mergeOfferDate": "2022-08-15T19:36:11.000Z",
  "mergeRequestDate": "2022-08-15T23:57:45.000Z",
  "mergeRequestUser": "koichik",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-relay",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-relay/relay-hooks/EntryPointTypes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-relay/test/relay-hooks-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "edvinerikson"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-08-15T19:35:28.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1179486187,
  "ciResult": "pass"
}

typescript-bot avatar Jul 09 '22 06:07 typescript-bot

🔔 @alloy @maraisr @edvinerikson — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot avatar Jul 09 '22 06:07 typescript-bot

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-relay (unpkg)

was missing the following properties:

  1. MutationTypes
  2. RangeOperations

Generated by :no_entry_sign: dangerJS against ca313b48a10080b0f666fbbd424dbf72c21708fe

DangerBotOSS avatar Jul 09 '22 06:07 DangerBotOSS

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @koichik.

(Ping @alloy, @maraisr, @edvinerikson.)

typescript-bot avatar Aug 05 '22 03:08 typescript-bot

@koichik: Everything looks good here. I am ready to merge this PR (at ca313b4) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@alloy, @maraisr, @edvinerikson: you can do this too.)

typescript-bot avatar Aug 15 '22 19:08 typescript-bot

Ready to merge

koichik avatar Aug 15 '22 23:08 koichik