hass-shutter-card icon indicating copy to clipboard operation
hass-shutter-card copied to clipboard

why using "was opened" instead of "open"

Open migueldc73 opened this issue 2 years ago • 8 comments

Superb frontend, I really love it !

I just wonder why you use "was opened" instead of the shorter and more common "open"

This is really an issue for me as I have my covers in 3 rows and the "was opened" and "was closed" text is so long it wraps and shifts the whole button a few pixel down/up when going from percentage to open or closed

migueldc73 avatar Aug 04 '23 08:08 migueldc73

One more for this. For me it does not make sense and uses valuable space. Some versions back it only says open or close.

mochoandre avatar Aug 11 '23 02:08 mochoandre

I don't understand the choice here... Is there anyway we can fix it by ourselves since updates seem very scarce...

DarKOrange75 avatar Oct 14 '23 20:10 DarKOrange75

If someone find the corresponding labels of "ui.components.logbook.messages.was_closed" and "ui.components.logbook.messages.was_opened", I'll update it with them :) .

Deejayfool avatar Jan 03 '24 09:01 Deejayfool

i don't understand what to do , do we have to change something by ourself somewhere ? rem: ui.components.logbook.messages.was_closed isn't the right label to use because this the old state and the current one

jluc2808 avatar Jan 03 '24 12:01 jluc2808

No, I can update the card with the good labels, but I don't know where is the list of labels. It was an other contributor who chose the labels "was_closed" and "was_opened", but I guess the good labels are somewhere else. If someone find them, just let me know and I'll update it.

Deejayfool avatar Jan 03 '24 12:01 Deejayfool

It looks like the problem was on Homeassistant side. From some time now it is good and only says open or closed

mochoandre avatar Jan 04 '24 00:01 mochoandre

@mochoandre it's not ok for me , i always have "était fermé" or "était ouvert" in french and never "fermé" ou "ouvert".

i have tried to install a fork with "wired label" or the fork of @Criban but for some unknown reason it seems that the old code is still used. I have modified the code directly under config/www/community/hass-shutter-card/hass-shutter-card.js , save, restart HA, but still with the old code running, do i have to make another action ?

jluc2808 avatar Jan 04 '24 07:01 jluc2808

as the @Criban fork have some problems (error message : this is not défined) i follow his modification (thanks a lot to @Criban) i have created a new fork to add optional text:

  • text_opened
  • text_closed
  • text_no_position (for RTS or other shutter without return position)

you could find the new fork : https://github.com/jluc2808/hass-shutter-card

the fork could be installed with HACS, while adding personnal repository: https://github.com/jluc2808/hass-shutter-card when done with HACS this will overwrite the hass_shutter_card already installed you could use without a restart of HA

jluc2808 avatar Jan 06 '24 13:01 jluc2808