database_cleaner icon indicating copy to clipboard operation
database_cleaner copied to clipboard

Nobrainer support

Open kp666 opened this issue 5 years ago • 4 comments

Would it be possible to have a rethinkdb support, and would it be possible to achieve it with the current database cleaner?

kp666 avatar May 31 '20 08:05 kp666

Hi @kp666, thanks for the issue!

The current release of database_cleaner is v1.8.5. This release has the list of supported ORMs hard-coded into it, so, no, it is not possible to use the current release with the nobainer ORM for RethinkDB.

However, we're very close to releasing v2.0.0, which splits all the ORM adapters out into a gem for each ORM, and makes it easy for someone to create a new adapter, just like you are suggesting! In fact, yesterday we released version 2.0.0.beta2 of database_cleaner-core (the gem that you would create the rethink adapter with) so that people can test it and discover issues, so this is a perfect opportunity for a motivated individual such as yourself to create database_cleaner-nobrainer!

Instructions for how to do this can be found in the ADAPTERS.md file in this repo. I'm personally invested in making sure it's easy to create a new adapter, so I'm happy to help if you have questions!

botandrose avatar May 31 '20 13:05 botandrose

Thanks for the update. Let me see what can be done.

kp666 avatar May 31 '20 14:05 kp666

Hello @kp666,

I just made one version here. If you'd like to give it a try, feel free to give me your feedback 😉.

zedtux avatar Oct 06 '20 16:10 zedtux

BTW @botandrose, would you like to add my gem to the list of adapters, or would you like to take it in your github group?

zedtux avatar Nov 03 '20 06:11 zedtux