chef-datadog icon indicating copy to clipboard operation
chef-datadog copied to clipboard

catch up datadog.conf default values

Open chicks-net opened this issue 8 years ago • 2 comments

According to datadog support:

You also have two additional params in datadog.conf - dogstatsd_interval & dogstatsd_normalize, both those have been deprecated in the latest versions of the agent. We no longer include those in the configuration comments.

Can you remove those fields from the cookbook-installed config file? Or make them both optional and change the default attributes so they aren't included? https://github.com/DataDog/chef-datadog/blob/master/templates/default/datadog.conf.erb

It also seems that

dogstatsd_target: http://localhost:17123 [...] isn't necessary. This param is optional in case you want to bypass the default behavior.

Can you find a default for this that works better? Currently it is not optional and it seems like what I should do is comment out this line, but it isn't optional in your template. https://github.com/DataDog/chef-datadog/blob/master/templates/default/datadog.conf.erb#L105

chicks-net avatar Aug 30 '17 21:08 chicks-net

Hi @chicks-net!

By default, the 3 configuration options you've mentioned are set by this cookbook to the same values as those the agent uses by default, so even though the cookbook always writes the values in datadog.conf it doesn't affect the agent.

The first 2 you mentioned (dogstatsd_interval and dogstatsd_normalize) are indeed deprecated in the agent. As removing them from the cookbook is a breaking change, it should be slated for the next major release.

olivielpeau avatar Sep 07 '17 00:09 olivielpeau

I don't understand why these matter, but datadog support thinks this is preventing my custom metrics from making it through. Considering that these values are defaults as you say it seems they might be confused, but I need to get them out of my config which is generated by chef before I can make further progress with support so I'd appreciate it if you could push a new release soon.

chicks-net avatar Sep 07 '17 20:09 chicks-net