ngit-cli icon indicating copy to clipboard operation
ngit-cli copied to clipboard

send.rs:in_reply_to_mentions_issue:test

Open RandyMcMillan opened this issue 1 year ago • 13 comments

use nostr::serde_json explicitly

RandyMcMillan avatar Sep 19 '24 17:09 RandyMcMillan

applied cargo +nightly fmt to tests/ngit/send.rs

RandyMcMillan avatar Sep 19 '24 18:09 RandyMcMillan

I'm not sure what you are trying to achieve here? If you are suggesting changing the version of fmt to use, please do so using nix?

DanConwayDev avatar Sep 20 '24 08:09 DanConwayDev

When using ngit as a library and not building in nix - it wasnt available when running tests. maybe out of scope - no biggie! :)

great work btw!

RandyMcMillan avatar Sep 20 '24 10:09 RandyMcMillan

When using ngit as a library and not building in nix - it wasnt available when running tests. maybe out of scope - no biggie! :)

great work btw!

O cool. I didn't consider that. Please package the changes together into a single commit / PR and I'd be apply them.

DanConwayDev avatar Sep 20 '24 10:09 DanConwayDev

please list what PRs you would like to include. I closed the others - I will stack them.

RandyMcMillan avatar Sep 20 '24 10:09 RandyMcMillan

you can also just cherry-pick them and do what ever - squash them etc...

RandyMcMillan avatar Sep 20 '24 10:09 RandyMcMillan

I will add some cargo docs stubs and add a little more documentation in another PR

RandyMcMillan avatar Sep 20 '24 11:09 RandyMcMillan

maybe i will do it over nostr - good testing. :)

RandyMcMillan avatar Sep 20 '24 11:09 RandyMcMillan

it may be a good test - due to my repo has completely diverged and we can test submitting PRs from a divergent repo. (should work)

RandyMcMillan avatar Sep 20 '24 11:09 RandyMcMillan

your git testing is great... i have some ideas for asynchronous git operations...

RandyMcMillan avatar Sep 20 '24 11:09 RandyMcMillan

also - i have implemented the "expensive tests" as a feature (tokio async) so those can be run separately... i will put together a PR.

RandyMcMillan avatar Sep 20 '24 11:09 RandyMcMillan

please list what PRs you would like to include. I closed the others - I will stack them.

I meant if you were making changes to a number of files so that it passes +nightly fmt then it would be best to include them in a single commit.

DanConwayDev avatar Sep 20 '24 13:09 DanConwayDev

I look foward to seeing what you come up with :)

DanConwayDev avatar Sep 20 '24 13:09 DanConwayDev