DeepNLP-models-Pytorch icon indicating copy to clipboard operation
DeepNLP-models-Pytorch copied to clipboard

about pretrained embeddings

Open ShellingFord221 opened this issue 6 years ago • 1 comments

Hi, I have a little question about file 08.CNN-for-Text-Classification.ipynb, [96], line 4: pretrained.append(model[word2index[key]]). word2index[key] means to find key's index, then you should find its pretrained embedding in GoogleNews-vectors-negative300.bin. But the index in this bin file should be different from the index generated from TREC dataset, i.e. model[key's index] may not be this key's (word's) embedding. Thanks!

ShellingFord221 avatar Feb 25 '19 11:02 ShellingFord221

Hi, Yeah you're right. There are some bugs in this project.. However, I don't have enough time to deal with issues in ad-hoc manner. So I'm preparing version-up of this repo. Thank you

DSKSD avatar Feb 26 '19 01:02 DSKSD