Dustin L. Howett

Results 663 comments of Dustin L. Howett

It'll come back with the next merge set (I'd like to bring main out to inbox before merging inbox back into main due to how diverged they are)

Looks like somebody is trying to set the icon by literally telling the window manager to replace it. Hm.

If you have a reason to _detect if you are running inside terminal_, we should probably have the discussion as to **why you want to detect that.** Any behavior you...

(I'm going to keep this open as a question/discussion topic.)

This cannot be known generally. ssh.exe from Windows to sshd.exe on Windows will usually be using the normal console host (conhost) as its host, but with specific requirements. If an...

> its clearly the old conhost. Which, on Windows 10+, supports a whole host of control sequences... which muddies the water significantly.

Alas! You've unfortunately stumbled into one of our known-bad rendering issues. Sorry about that. I just had a trip over the repo, and it seems like we did lose track...

> (Future improvement:) Looking at `_commandDelimiterRegex`, I get the feeling that this code would be a lot more robust if we'd just `find(L';')` and check if the preceding character is...

This vaguely worries me, actually. Why are we using a regex to match a character followed by `;` when what we want to know is _whether there is a `;`_?...

Wait, the package's actual system-level ID has not changed¹. Are you telling me they're going by the "Visual Element" display name? That would be madness. ¹ We're still `Microsoft.WindowsTerminal{,Preview}_8wxxxxxxx`... and...