df-structures icon indicating copy to clipboard operation
df-structures copied to clipboard

`job.item_category` needs to be renamed and retyped

Open ab9rf opened this issue 2 years ago • 0 comments

this field is both mistyped and misnamed; it's not a stockpile_group_set and is called specflag in toady code

the field encodes multiple overlapping bits depending on job type:

  • bit0: ConstructBuildingSwitchedSpot, CleanPatientTriedSoap, CleanSelfTriedSoap, PlaceTrackVehicleClearedJobs, GatherFromZone, DrinkItemLookedForNearbyGoblet, InterrogationDidOfficeAttempt
  • bit1: GatherPickTrees
  • bit2: GatherPickShrubs
  • bit3: GatherGatherFallen
  • bit4: GatherNoLadderSearch
  • bit5: GatherLadderRestricted
  • bit6: GatherLadderGround

however there are multiple references in code to this field so renaming it requires coordination

ab9rf avatar Oct 04 '23 05:10 ab9rf