Artem Medvedev

Results 98 comments of Artem Medvedev

It works now in #9318 For `ReparitionExec` I had to wrap each task into `JoinSet` and collect them to `Vec` to guarantee the order We still can refactor this somehow...

> Another potential cancelation safety issue to consider in the referenced code is use of https://docs.rs/tokio/latest/tokio/io/trait.AsyncWriteExt.html#method.write_all which is not cancel safe. > > I don't think the consequences will be...

Oh, got it, in that case the issue should be redirected, since there seems to be a difference in the behavior of the implementations for different languages. Thanks

Yes, I think so, the behavior will be documented. Let's close the issue. Thank you!

> I haven't anticipated anyone would like to use both together... I think it's not that weird, for example the output depends on some input params, so we can use...

Hi there! As far as I understand to use `Scatter` instead of `Line` chart we need to be able to set `showLine: true`, but currently I don't see this property....

Thanks @Billy-Sheppard, it works as expected to me

Sure, thank you for implementing this! 🙏

Since this is only for testing, we can easily specify this as a prerequisite for running tests (contributing guide #1?) and update our CI. This will not affect users of...

Two remaining tasks are: - Document usage of each existing module We have a number of modules which has been moved from `testcontainers` repo, most of them don't have a...