openbor

openbor copied to clipboard

Description

Executing loadsprite() stops in game music if the target sprite file is unavailable.

Debugging

Reproduce

1. Open any level with music (tested with .ogg).
2. During level, execute loadsprite(), with an invalid directory or non existent file name. My test used "data/chars/blank.png" when the file is actually located at "data/chars/misc/blank.png". The loadpsrite() function was executed by an entity spawned at location 0 0 0 (i.e. immediately at level start), using the model ondraw event.
3. In game music does not play. Nothing else appears affected.

Expected behavior

The loadpsrite() function should return an empty value on failure without affecting other functionality.

Screenshots

NA

Version

Discovered in Windows platform, revision 7094 (https://github.com/DCurrent/openbor/commit/d9ff4596baad6da6e1bbd1002bc9879974ff365d). I have not yet found the blame revision.

Edit: Format corrections.

Does this issue still exist in the current version?

@Plombo, I believe the issue is still there, but I need to retest. Right now we have some other more pressing issues. Your timing is really fortuitous. Just yesterday I created a branch that reverts your control changes, and we were about to pull it into the global_beta branch (I'll explain the global beta too if you need). There are a couple of deal breaking issues problems with it (control code). Probably better to discuss in forum if you want to stop by.

I'm tagging you on the thread in Developer Discussion.

The only reason I haven't been on Chrono Crash recently is that I thought there was a problem with my 2FA setup. I just realized it's actually fine, but I spent 3 months thinking I couldn't log in...

Anyway, if the issues with the control changes are just bugs, can they be entered as issues on here so I can keep track of them? I'm happy to discuss things, of course, but I can't even find where the Developer Discussion section went with the move to the new forum software.

I just thought maybe you'd gotten bored with OpenBOR and moved onto other stuff, lol. Sure, I'll make a bug entry. It's just easier to discuss things at length there, and some stuff I prefer not publicly viewable. It's in the same place as before, a sub category of Engine. Are you not able to see it?

Edit: I can answer that - No you can't. I had your permissions screwed up. Give me a sec and I'll fix.

@Plombo, Just reworked your permissions and ran an audit. You should be able to access the Dev area now. In the meantime I'll write up a detailed report soon as I can, have to leave my desk for a bit right now.