Crow icon indicating copy to clipboard operation
Crow copied to clipboard

Published 20 hours ago • verified publisher icon CrowCpp

support websocket compression

Open MichaelSB opened this issue 2 years ago • 2 comments

This adds support for websocket compression via permessage-deflate extension. It's based on https://github.com/ipkn/crow/pull/329, with a few changes to better match current crow. It resolves https://github.com/CrowCpp/Crow/issues/92 I was not able to use the current implementation of zlib. This needs state, which the current implementation does not support. It's enabled whenever CROW_ENABLE_COMPRESSION is defined. I tested it with my very websocket heavy app on recent chrome and firefox and it works as expected. Please let me know, if there's anything I need to change.

MichaelSB avatar Jul 01 '23 13:07 MichaelSB

May I ask you to provide unit tests?

mrozigor avatar Mar 09 '24 15:03 mrozigor

I'll try to add some unit-tests for this. Thanks for the review.

MichaelSB avatar Mar 10 '24 19:03 MichaelSB