Takuya Iwanaga
Takuya Iwanaga
Thanks @sitadrost , I'll try to make some time to have a look this weekend.
@sahin-abdullah please hold off doing a complete review at this stage, as I'm still working on providing better support for the ProblemSpec interface. Other comments welcome, however.
Hey @sahin-abdullah Tried the matrix multiplication outside the loops you did and saw the same performance regression you did. I don't think it's a memory copy issue like I suspected...
Merging after discussion with @sahin-abdullah Thanks @sahin-abdullah !
I've since generalized the above to: ```python def sobol_first(Y, X, m): # pre-process to catch constant array # see: https://github.com/numpy/numpy/issues/9631 if Y.ptp() == 0.0: # Catch constant results # If...
Thanks for your PR @DmitriyValetov I have made a few minor comments and changes for your review. The notebook is welcome, however I would like to place the notebook in...
> I will take a try. So, we need two tests: one for correlating and one correlated problem with analitical results? Yes, we can also re-use the example given in...
Yes, sounds good. We just need to be mindful of any licensing issues but you seem to have considered this already. I can review and provide any additional suggestions, just...
Just adding a reference to a related issue (#193)
Hi @mschrader15 The current implementation has dependencies on a few big external packages. We're currently looking into how best to reduce/remove these dependencies so that SALib continues to be relatively...