Maui.Markup icon indicating copy to clipboard operation
Maui.Markup copied to clipboard

add extension methods for SetAppTheme and SetAppThemeColor

Open fredericoregateiro opened this issue 3 years ago • 3 comments

Description of Change

Linked Issues

  • Fixes # #117

PR Checklist

  • [ ] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • [ ] Has tests (if omitted, state reason in description)
  • [ ] Has samples (if omitted, state reason in description)
  • [ ] Rebased on top of main at time of PR
  • [ ] Changes adhere to coding standard
  • [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls/XYZ

Additional information

fredericoregateiro avatar Sep 20 '22 00:09 fredericoregateiro

Thanks @fredericoregateiro!

Your Proposal Champion is @bijington and he will help guide you through the New Feature Proposal Process.

The Proposal for this feature, #117, must first be approved by the core maintainer team before we can review, approve and merge this PR. Shaun will bring this feature to a vote at our upcoming Monthly Standup meeting this Thursday.

After it is approved, we'll also need you to write the Docs by opening a PR on our Docs repo: https://github.com/MicrosoftDocs/CommunityToolkit/

I did take a quick look at this PR and noticed a few things missing:

  • [ ] Add Unit Tests
  • [ ] Update the Sample App to display the use of the new feature.

Thanks again for your hard work!

TheCodeTraveler avatar Oct 03 '22 21:10 TheCodeTraveler

Thanks @brminnick I'll be updating those taks as soon as i can

fredericoregateiro avatar Oct 04 '22 10:10 fredericoregateiro

Thanks @brminnick I'll be updating those taks as soon as i can

Thanks @fredericoregateiro, do let me know if you need any assistance with the tasks as I am here to assist in any way 👍

bijington avatar Oct 09 '22 18:10 bijington

Docs are ready to go afaic

jfversluis avatar Oct 31 '22 08:10 jfversluis