Maui.Markup
Maui.Markup copied to clipboard
add extension methods for SetAppTheme and SetAppThemeColor
Description of Change
Linked Issues
- Fixes # #117
PR Checklist
- [ ] Has a linked Issue, and the Issue has been
approved(bug) orChampioned(feature/proposal) - [ ] Has tests (if omitted, state reason in description)
- [ ] Has samples (if omitted, state reason in description)
- [ ] Rebased on top of
mainat time of PR - [ ] Changes adhere to coding standard
- [ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls/XYZ
Additional information
Thanks @fredericoregateiro!
Your Proposal Champion is @bijington and he will help guide you through the New Feature Proposal Process.
The Proposal for this feature, #117, must first be approved by the core maintainer team before we can review, approve and merge this PR. Shaun will bring this feature to a vote at our upcoming Monthly Standup meeting this Thursday.
After it is approved, we'll also need you to write the Docs by opening a PR on our Docs repo: https://github.com/MicrosoftDocs/CommunityToolkit/
I did take a quick look at this PR and noticed a few things missing:
- [ ] Add Unit Tests
- [ ] Update the Sample App to display the use of the new feature.
Thanks again for your hard work!
Thanks @brminnick I'll be updating those taks as soon as i can
Thanks @brminnick I'll be updating those taks as soon as i can
Thanks @fredericoregateiro, do let me know if you need any assistance with the tasks as I am here to assist in any way 👍
Docs are ready to go afaic