gebaar-libinput

gebaar-libinput copied to clipboard

…s recognition if only vertical and horizontal swipes are used.

I think it's better to add a [[general]] section to the configuration file and add a toggle there like oblique = true, for performance reasons

Or check if one of the oblique commands is set, and then set an oblique flag, which can be checked in the if statement checking for oblique swipes.

@oryasida that would have a nasty side effect, what if only that oblique command isn't set and the rest is?

How is that different from what you're proposing? If one of the oblique commands is set, we check for all of them, if none we don't check for any. Otherwise, this commit does (as far as I can tell) the other possibility, if the found oblique swipe is set we do it, if not, it does the nearest non oblique swipe.

I rather meant that checking for one then all is implicit configuration, I'm more a fan of explicit configuration.

if oblique = true is set in [[general]], then run the oblique commands and check for oblique motion.
if oblique = false is set in [[general]], then ignore the oblique commands and don't check for oblique motion.

This also gives the advantage of being able to toggle the oblique commands on and off without having to remove them from the config file.

Or I must be misunderstanding things and badly explaining things because it's getting quite late here and I'm quite tired :stuck_out_tongue:

With my changes I had the following in mind: If you don't have oblique commands set, you probably want a bit more flexibility with making your horizontal/vertical gestures and only want to detect those. Maybe you now add one oblique command; you want that one recognized, but still want a bit more flexibility drawing your gestures into the other directions. If you have all four oblique commands set, my changes do not change the current behavior.

@Coffee2CodeNL I see what you mean, explicit configuration does sound like a better solution. But it would still have the disadvantage of either having oblique commands entirely off or entirely on. For example: If the only oblique command set is left_down, and up,down,left,right are also set, then there is no reason to check for the right_up gesture, and it could fall back to either up or right (depending on whats more dominant). With a global oblique toggle, if it is set to true then the right_up gesture would get recognized for no reason. As far as I can tell this commit in this case would ignore the right_up gesture since it is not set (even though the leg_down gesture is set).

I'll think about it for a bit for the rest of the evening and tomorrow, probably some hybrid/combined solution and/or splitting up the responsibilities (detection vs checking vs execution)

Who knows, we could add multi-threading and separate input from execution completely for performance reasons :man_shrugging:

Or is that too crazy? :stuck_out_tongue:

I'd also like to invite both of you to the Discord server, makes brainstorming a bit easier and keeps PRs straight to the point and on topic, see the Readme for the link.